feat(core): disable tui when output style is set to an incompatible style#30873
Merged
AgentEnder merged 1 commit intomasterfrom May 1, 2025
Merged
feat(core): disable tui when output style is set to an incompatible style#30873AgentEnder merged 1 commit intomasterfrom
AgentEnder merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit fb05864.
☁️ Nx Cloud last updated this comment at |
8fc8d52 to
64f74ad
Compare
64f74ad to
b971b5e
Compare
b971b5e to
5a68675
Compare
JamesHenry
reviewed
Apr 28, 2025
Contributor
There was a problem hiding this comment.
Wouldn't it help with cohesiveness of options and configuration to go for --output-style=tui when being explicit? One less thing for folks to hold in their head that dynamic === tui.
Existing things:
nx.json
"tui": { ... }Env var
NX_TUI=...CLI option
--tui-auto-exit=...New thing:
CLI option
--output-style=tui5a68675 to
941a65a
Compare
941a65a to
5386f73
Compare
5386f73 to
63109d8
Compare
FrozenPandaz
approved these changes
Apr 30, 2025
Contributor
FrozenPandaz
left a comment
There was a problem hiding this comment.
Fix these up and it's good to go
63109d8 to
2b9a40e
Compare
843fb81 to
d6ebd65
Compare
d6ebd65 to
fb05864
Compare
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Setting
--output-styledoes not do anything when the tui is enabledExpected Behavior
If
--output-styleis set tostatic,stream, ordynamic-legacy, the tui is disabled. If the--output-styleis set todynamic, the tui is enabled.Related Issue(s)
Fixes #