fix(core): do not clone screen on every render loop of the TUI#30872
Merged
FrozenPandaz merged 1 commit intomasterfrom Apr 25, 2025
Merged
fix(core): do not clone screen on every render loop of the TUI#30872FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 46eed24.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Apr 25, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Everytime the TUI is rendered with a terminal pane opened, we clone the screen. This cloning is resource intensive as we would be creating a new screen every couple of milliseconds.
Expected Behavior
This has changes so that we can pass a reference to the screen to be used in places where its needed. This avoids the cloning the screen.
Related Issue(s)
Fixes #