Skip to content

feat(core): bump devkit support range and remove some deprecated APIs#30840

Merged
AgentEnder merged 1 commit intomasterfrom
devkit-cleanup
May 1, 2025
Merged

feat(core): bump devkit support range and remove some deprecated APIs#30840
AgentEnder merged 1 commit intomasterfrom
devkit-cleanup

Conversation

@FrozenPandaz
Copy link
Copy Markdown
Contributor

@FrozenPandaz FrozenPandaz commented Apr 23, 2025

Current Behavior

Expected Behavior

BREAKING CHANGE

The readNxJson signature which did not require a Tree to be passed in was marked as deprecated in Nx 20 and is now removed.

Related Issue(s)

Fixes #

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 1, 2025 2:26pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 23, 2025

View your CI Pipeline Execution ↗ for commit 53f5c01.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 39m 13s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 2m 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-01 15:01:21 UTC

Comment thread packages/nx/src/command-line/report/report.ts
Comment thread packages/nx/src/utils/ignore.ts
@FrozenPandaz FrozenPandaz marked this pull request as ready for review May 1, 2025 15:57
@FrozenPandaz FrozenPandaz requested review from a team as code owners May 1, 2025 15:57
Comment on lines +46 to 49
* TODO(v22): Stop sorting tsconfig paths by default, paths are now less common/important
* in Nx workspace setups, and the sorting causes comments to be lost.
*/
default: true,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just go ahead and flip this and remove the todo?

@AgentEnder AgentEnder changed the title feat(core): bump devkit support ragne and remove some deprecated APIs feat(core): bump devkit support range and remove some deprecated APIs May 1, 2025
@AgentEnder AgentEnder merged commit e5dc244 into master May 1, 2025
6 checks passed
@AgentEnder AgentEnder deleted the devkit-cleanup branch May 1, 2025 18:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants