feat(linter): add support for package based secondary entry points#30809
Merged
feat(linter): add support for package based secondary entry points#30809
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 0fc58c0.
☁️ Nx Cloud last updated this comment at |
4 tasks
52238cf to
4647209
Compare
| return []; | ||
| } | ||
| const entryPaths: Array<{ path: string; file: string }> = []; | ||
| for (const [key, value] of Object.entries<string>(exports)) { |
Contributor
Author
There was a problem hiding this comment.
Thanks, let me rework that.
| if (key !== '.' && key !== './') { | ||
| entryPaths.push({ | ||
| path: joinPathFragments(projectRoot, key), | ||
| file: joinPathFragments(projectRoot, value), |
Member
There was a problem hiding this comment.
The value here could be a string, but it could also be an object with conditional exports. It can also be null to disable the entry point from being used.
| projectRoot | ||
| function getEntryPoint(file: string, projectRoot: string): string { | ||
| const packageEntryPoints = getPackageEntryPoints(projectRoot); | ||
| const fileEntryPoint = packageEntryPoints.find( |
Member
There was a problem hiding this comment.
The entry points could have patterns (*), which would require a more complex matching to find whether an import matches a given entry point.
Contributor
Author
There was a problem hiding this comment.
Let's handle this later if users request it. I'm worried this might impact performance significantly so I would not add it unless requested.
| for (const [key, value] of Object.entries<string>(exports)) { | ||
| if (key !== '.' && key !== './') { | ||
| entryPaths.push({ | ||
| path: joinPathFragments(projectRoot, key), |
Member
There was a problem hiding this comment.
The key could be the condition name of a conditional export.
992695f to
0fc58c0
Compare
leosvelperez
approved these changes
Apr 25, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 25, 2025
…30809) This PR adds support for package.json based secondary entry points and implements fix for situation when package imports base entry point as dynamic dependency and secondary entry point as static dependency. ## Current Behavior When the package is imported from itself, check for a secondary entry point checks only Angular-style secondary entry points. When package is importing from the same library as dynamic import from root and static import from secondary entry point we still get linter errror. ## Expected Behavior Check for secondary entry points should also support standard package.json-based entry points. Importing from the same library as dynamic import from root and static import from secondary entry point should be allowed. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #18552 (cherry picked from commit cd55dfc)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for package.json based secondary entry points and implements fix for situation when package imports base entry point as dynamic dependency and secondary entry point as static dependency.
Current Behavior
When the package is imported from itself, check for a secondary entry point checks only Angular-style secondary entry points.
When package is importing from the same library as dynamic import from root and static import from secondary entry point we still get linter errror.
Expected Behavior
Check for secondary entry points should also support standard package.json-based entry points.
Importing from the same library as dynamic import from root and static import from secondary entry point should be allowed.
Related Issue(s)
Fixes #18552