fix(release): ensure generatorOptions and rootVersionActions options are passed to updateLockfile function#30796
Merged
JamesHenry merged 8 commits intonrwl:masterfrom Apr 25, 2025
Conversation
…sed to updateLockfile function
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 45c4386.
☁️ Nx Cloud last updated this comment at |
Contributor
Author
|
@JamesHenry you're welcome!. Happy to see the release command has received so much attention recently. Looks promising! CI still fails for this PR though but I don't think that could be caused by these changes. Locally everything is green. |
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx release versionby default will also run package manager commands to update the lockfile after packages have been versioned. Example for npm it will runnpm install --lock-file-only. There used to be a flag to disable this behavior but that flag is no longer working.Expected Behavior
With legacy versioning, one should be able to set
release.version.skipUpdateLockfiletotrueto prevent nx to run any package manager commands to automatically update the lockfile after packages have been versioned.The new versioning logic introduced in nx 20.8.0 (opt in) should also have an option to disable this behavior.
Related Issue(s)
Fixes #30793