feat(core)!: remove legacy cache flag from nx.json#30787
Merged
AgentEnder merged 5 commits intomasterfrom Apr 29, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 902b817.
☁️ Nx Cloud last updated this comment at |
3209542 to
0d2c18e
Compare
0d2c18e to
cc1e13a
Compare
cc1e13a to
5cedb95
Compare
5cedb95 to
51b11a5
Compare
FrozenPandaz
requested changes
Apr 24, 2025
| @@ -0,0 +1,27 @@ | |||
| #### Use Legacy Cache | |||
|
|
|||
| Removes `useLegacyCache` as it is no longer functional in Nx 21 | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Removes `useLegacyCache` as it is no longer functional in Nx 21 | |
| Removes `useLegacyCache` from `nx.json` as it is no longer functional in Nx 21 |
| return; | ||
| } | ||
|
|
||
| // If workspaces had `enableDbCache` we can just delete the property as the db cache is enabled by default in nx v20 |
Contributor
There was a problem hiding this comment.
This comment doesn't make sense
|
|
||
| // If workspaces had `enableDbCache` we can just delete the property as the db cache is enabled by default in nx v20 | ||
| if ((nxJson as any).useLegacyCache) { | ||
| delete (nxJson as any).enableDbCache; |
Contributor
There was a problem hiding this comment.
Suggested change
| delete (nxJson as any).enableDbCache; | |
| delete (nxJson as any).useLegacyCache; |
FrozenPandaz
approved these changes
Apr 24, 2025
| } | ||
| if (nextSteps.length > 0) { | ||
| output.log({ | ||
| title: `Some migrations require additional steps to be completed, please check the following:`, |
Contributor
There was a problem hiding this comment.
Suggested change
| title: `Some migrations require additional steps to be completed, please check the following:`, | |
| title: `Some migrations have additional information. See below:`, |
| if (!Array.isArray(value)) { | ||
| return false; | ||
| } | ||
| return value.reduce((acc, v) => acc && typeof v === 'string', true); |
Contributor
There was a problem hiding this comment.
Suggested change
| return value.reduce((acc, v) => acc && typeof v === 'string', true); | |
| return value.every((v) => typeof v === 'string'); |
| } | ||
| if (nextSteps.length) { | ||
| output.log({ | ||
| title: 'Some next steps may be necessary to complete the repair:', |
Contributor
There was a problem hiding this comment.
Suggested change
| title: 'Some next steps may be necessary to complete the repair:', | |
| title: 'Some repairs have additional information. See below:', |
|
|
||
| import type { NxJsonConfiguration } from './nx-json'; | ||
| import { Schema } from '../utils/params'; | ||
| import { Tree } from '../generators/tree'; |
| @@ -8,6 +8,7 @@ import { | |||
|
|
|||
| import type { NxJsonConfiguration } from './nx-json'; | |||
| import { Schema } from '../utils/params'; | |||
|
|
||
| #### Sample Code Changes | ||
|
|
||
| Removes `tasksRunnerOptions` from `nx.json` if it would be empty after removing custom tasks runners. |
Contributor
There was a problem hiding this comment.
Suggested change
| Removes `tasksRunnerOptions` from `nx.json` if it would be empty after removing custom tasks runners. | |
| Removes custom task runner configuration from `nx.json` |
2e6f7fa to
aac22fc
Compare
aac22fc to
902b817
Compare
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
useLegacyCache is there for opting out of db cache impl
Expected Behavior
db cache is only cache when at all possible, unfortunately on wasm builds it is still unsupported.
Related Issue(s)
Fixes #