fix(core): only register forced shutdown when tui is enabled#30735
Merged
FrozenPandaz merged 1 commit intomasterfrom Apr 15, 2025
Merged
fix(core): only register forced shutdown when tui is enabled#30735FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 3a192a4.
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
Apr 15, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
registerForcedShutdownCallbacklifecycle hook does not exist if the TUI is not enabled as it is not on CI. But Nx tries to invoke it anyways so it causes an error in CI: https://github.com/nrwl/nx/actions/runs/14471341199/job/40585817051?pr=30710#step:11:31Expected Behavior
The
registerForcedShutdownCallbackis only utilized when the TUI is enabled so it will not be invoked on CI where it does not exist.Related Issue(s)
Fixes #