Skip to content

fix(webpack): add extension alias support for handling ESM libs#30513

Merged
ndcunningham merged 1 commit intomasterfrom
fix/webpack-ts-solution
Mar 28, 2025
Merged

fix(webpack): add extension alias support for handling ESM libs#30513
ndcunningham merged 1 commit intomasterfrom
fix/webpack-ts-solution

Conversation

@ndcunningham
Copy link
Copy Markdown
Contributor

Current Behavior

Currently, if you have a webpack application that uses out NxWebpackAppPlugin and has a non-buildable lib that has exports with extension enabled for example:export * from './lib/lib8446520.js';.
The app fails to build.

Expected Behavior

When using webpack and including libraries that contain extension it should resolve.

Related Issue(s)

Fixes #30492

@ndcunningham ndcunningham self-assigned this Mar 26, 2025
@ndcunningham ndcunningham requested review from a team as code owners March 26, 2025 18:58
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 5:20pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Mar 26, 2025

View your CI Pipeline Execution ↗ for commit 9b9b992.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 24m 34s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 20s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=90ff0... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-28 17:47:54 UTC

@ndcunningham ndcunningham force-pushed the fix/webpack-ts-solution branch from 404ba10 to afe7580 Compare March 28, 2025 16:19
@ndcunningham ndcunningham force-pushed the fix/webpack-ts-solution branch from afe7580 to 9b9b992 Compare March 28, 2025 17:18
@ndcunningham ndcunningham merged commit bf8848d into master Mar 28, 2025
12 checks passed
@ndcunningham ndcunningham deleted the fix/webpack-ts-solution branch March 28, 2025 17:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webpack build does not add local libraries to bundled js file

2 participants