fix(core): init should use pr version when specified#30497
Merged
AgentEnder merged 1 commit intomasterfrom Mar 26, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 59b6bdd.
☁️ Nx Cloud last updated this comment at |
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx initalways either installsnextorlatestversions of Nx. The intent here is that runningnpx nx initshould always provide the latest version of Nx, and we added a condition to usenextif we detected a beta version of Nx was running to facilitate easier testing of RC and beta releases. The full logic to determine which version of Nx to setup is below:The goal here was to avoid hitting the
npxcache and accidentally creating new workspaces with an older Nx version. This logic falls apart a bit when considering prereleases though, asnpx nx@next initwould always check the tag to make sure its up to date rather than using a cached version. This is the case when providing any tag tonpx.A bad side effect of the above is that when trying to test PR builds and the like,
nx initwill never setup the PR build when runningnpx nx@0.0.0-pr....opting instead to setupnext.Expected Behavior
Running
npx nx@0.0.0-pr.... initsets up an nx workspace using the specified PR release.Related Issue(s)
Fixes #