feat(react): add crystal mf support to host and remote#30424
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit ad2c6b4.
☁️ Nx Cloud last updated this comment at |
6b1678c to
5bbd239
Compare
c4ea75e to
23641be
Compare
dee9678 to
1933b50
Compare
4 tasks
afe91d7 to
a801feb
Compare
a801feb to
ef2b52c
Compare
jaysoo
reviewed
Apr 2, 2025
jaysoo
approved these changes
Apr 2, 2025
Member
jaysoo
left a comment
There was a problem hiding this comment.
Left two comments (one is a question), but it looks good overall.
ndcunningham
reviewed
Apr 2, 2025
ndcunningham
approved these changes
Apr 2, 2025
leosvelperez
approved these changes
Apr 2, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/reacthostandremotegenerators currently use executors to support Module FederationExpected Behavior
When
bundler=rspackuse Crystal Module Federation with no executors for Module FederationRelated Issues
#30391