Skip to content

fix(core): make 'key' parameter optional in register command#30365

Merged
Cammisuli merged 1 commit intomasterfrom
cammisuli/make-key-optional
Mar 13, 2025
Merged

fix(core): make 'key' parameter optional in register command#30365
Cammisuli merged 1 commit intomasterfrom
cammisuli/make-key-optional

Conversation

@Cammisuli
Copy link
Copy Markdown
Member

Current Behavior

Calling nx register requires users to enter a key.

Expected Behavior

Calling nx register should work without having users enter a key.

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested a review from a team as a code owner March 13, 2025 18:28
@Cammisuli Cammisuli requested a review from MaxKless March 13, 2025 18:28
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2025 6:30pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Mar 13, 2025

View your CI Pipeline Execution ↗ for commit e1818a8.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 37m 24s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=cc9e9... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 53s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-13 19:12:06 UTC

@Cammisuli Cammisuli enabled auto-merge (squash) March 13, 2025 18:50
@Cammisuli Cammisuli merged commit b060079 into master Mar 13, 2025
@Cammisuli Cammisuli deleted the cammisuli/make-key-optional branch March 13, 2025 19:12
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Mar 14, 2025
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Mar 14, 2025
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Mar 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants