fix(vite): ensure paths with explicit extensions are resolved #29948#30202
Merged
fix(vite): ensure paths with explicit extensions are resolved #29948#30202
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 3fa24fa.
☁️ Nx Cloud last updated this comment at |
ndcunningham
approved these changes
Feb 27, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When TS Path Mappings are combined with an explicit extension of the build outcome of a file, the
nxViteTsPathsplugin cannot resolve the file.e.g.
In this case, we fallback to the file system to try find the file, and we do it by adding extensions to the end of the path.
e.g.
Expected Behavior
Perform the usual logic first to try find the file in the file system.
If the file is still not resolved AND the path ends with an
extnamethat we support inoptions.extensions, strip the extension from the path and try append the different extensions again and resolve against the filesystem.This allows for the case where someone has a file in their file system that is
file.js.jsto be resolve via@mylib/file.jsas well as when the explicit path is provided.Related Issues
Fixes #29948