Skip to content

fix(esbuild): update peerDep range#30167

Merged
Coly010 merged 1 commit intomasterfrom
esbuild/update-version
Feb 25, 2025
Merged

fix(esbuild): update peerDep range#30167
Coly010 merged 1 commit intomasterfrom
esbuild/update-version

Conversation

@Coly010
Copy link
Copy Markdown
Contributor

@Coly010 Coly010 commented Feb 25, 2025

Current Behavior

esbuild has a security advisory for versions up to 0.24.
If users attempted to install a version greater than 0.19, they would face peer dep issues with the @nx/esbuild package.

Expected Behavior

Expand the peerDep range for esbuild on the @nx/esbuild package to allow users to upgrade.
Keep the base version at a lower version to support older OS and VMs which are unsupported by newer versions of esbuild.

Closes #30009

@Coly010 Coly010 requested review from a team as code owners February 25, 2025 10:55
@Coly010 Coly010 requested a review from ndcunningham February 25, 2025 10:55
@Coly010 Coly010 self-assigned this Feb 25, 2025
@Coly010 Coly010 requested a review from xiongemi February 25, 2025 10:55
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 25, 2025 0:15am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Feb 25, 2025

View your CI Pipeline Execution ↗ for commit 4fa79fb.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 34m 46s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 5s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 42s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-25 12:45:30 UTC

@Coly010 Coly010 changed the title feat(esbuild): update peerDep range fix(esbuild): update peerDep range Feb 25, 2025
@Coly010 Coly010 merged commit 9cbd476 into master Feb 25, 2025
@Coly010 Coly010 deleted the esbuild/update-version branch February 25, 2025 13:54
@lppedd
Copy link
Copy Markdown

lppedd commented Feb 25, 2025

Doesn't this mean only 0.19.x releases anyway, given that it's a 0.x?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update esbuild version

4 participants