feat(linter): update allowed ESLint config file extensions#30127
Merged
FrozenPandaz merged 2 commits intonrwl:masterfrom Jun 9, 2025
Merged
feat(linter): update allowed ESLint config file extensions#30127FrozenPandaz merged 2 commits intonrwl:masterfrom
FrozenPandaz merged 2 commits intonrwl:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2e4b2a2 to
0e5be8c
Compare
Contributor
Author
|
Hey @leosvelperez is there anything I can do to help get this through? This is my first Nx PR so I'm sure I've missed some things |
Contributor
|
View your CI Pipeline Execution ↗ for commit 3714097.
☁️ Nx Cloud last updated this comment at |
0e5be8c to
fe57273
Compare
fe57273 to
52bcd8c
Compare
Member
|
@TorinFrancis thanks for taking the time to contribute! I'm sorry for the delay. Please rebase your changes and make sure that all unit tests pass. The CI checks were previously failing. |
52bcd8c to
3714097
Compare
leosvelperez
approved these changes
Jun 9, 2025
FrozenPandaz
approved these changes
Jun 9, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESLint added experimental support for typescript config files since 9.9.0, and as of 9.18.0 that support is stable. This PR add ts/mts/cts to the list of known eslint config files, and adds the same extensions to config file generators
Current Behavior
When using the eslint executor with a ts file, returns error "When using the new Flat Config with ESLint, all configs must be named eslint.config.js or eslint.config.cjs and .eslintrc files may not be used. See https://eslint.org/docs/latest/use/configure/configuration-files"
When using the eslint plugin, the inferred task is not created for projects that do not have a non-ts eslint config.
Workarounds
Expected Behavior
When using the eslint executor with a ts file, no error is thrown.
When using the eslint plugin with a ts file, the inferred task is created.
Related Issue(s)
No issues, but addresses this discussion