Skip to content

fix(js): use absolute filetorun path#30091

Merged
Coly010 merged 1 commit intonrwl:masterfrom
MisterPandaPooh:js/fix-serve-from-project-root
Feb 25, 2025
Merged

fix(js): use absolute filetorun path#30091
Coly010 merged 1 commit intonrwl:masterfrom
MisterPandaPooh:js/fix-serve-from-project-root

Conversation

@MisterPandaPooh
Copy link
Copy Markdown
Contributor

Fix a bug introduced in #30087

Current Behavior

The @nx/js plugins throw an error when the project is served in the project root but not in the workspace root.

Expected Behavior

Ensure that nx run $project:serve works correctly both in the workspace root and the project root, restoring the previous behavior.

Related Issue(s)

Fixes #30087

@MisterPandaPooh MisterPandaPooh requested a review from a team as a code owner February 18, 2025 14:29
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 8:57pm

@MisterPandaPooh MisterPandaPooh force-pushed the js/fix-serve-from-project-root branch from de669c8 to 756441c Compare February 18, 2025 20:39
@zivadler
Copy link
Copy Markdown

@MisterPandaPooh ci failed

@MisterPandaPooh MisterPandaPooh force-pushed the js/fix-serve-from-project-root branch from 756441c to d6eb478 Compare February 18, 2025 20:54
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Feb 25, 2025

View your CI Pipeline Execution ↗ for commit d6eb478.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 38m 45s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 57s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-25 11:34:22 UTC

@Coly010 Coly010 merged commit 4fc52cf into nrwl:master Feb 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot Serve Project from Project Root for a NestJS project

3 participants