Skip to content

fix(core): re-enable CRA migration to Vite#30082

Merged
jaysoo merged 6 commits intomasterfrom
fix/cra-init
Feb 25, 2025
Merged

fix(core): re-enable CRA migration to Vite#30082
jaysoo merged 6 commits intomasterfrom
fix/cra-init

Conversation

@jaysoo
Copy link
Copy Markdown
Member

@jaysoo jaysoo commented Feb 18, 2025 •
edited
Loading

This PR brings back the CRA migration that was missing since Nx 18.

Current Behavior

nx init does not migrate CRA apps

Expected Behavior

nx init migrates CRA apps to Vite since CRA is deprecated

Related Issue(s)

Fixes #

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 5:22pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Feb 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 63aa243.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 26m 33s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 7s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-25 17:53:08 UTC

@jaysoo jaysoo force-pushed the fix/cra-init branch 3 times, most recently from 55e49bf to 1f05c4d Compare February 18, 2025 18:29
@jaysoo jaysoo marked this pull request as ready for review February 18, 2025 18:30
@jaysoo jaysoo requested review from a team as code owners February 18, 2025 18:30
@jaysoo jaysoo force-pushed the fix/cra-init branch 6 times, most recently from c44121f to 8fdf221 Compare February 18, 2025 21:37
JamesHenry
JamesHenry previously requested changes Feb 19, 2025
View reviewed changes
Comment thread packages/nx/src/command-line/init/implementation/react/index.ts Outdated
@jaysoo jaysoo force-pushed the fix/cra-init branch 3 times, most recently from 3da42ee to b0f8cf6 Compare February 19, 2025 14:45
@jaysoo jaysoo requested a review from a team as a code owner February 19, 2025 17:57
@nrwl nrwl deleted a comment from github-actions Bot Feb 19, 2025
@nrwl nrwl deleted a comment from github-actions Bot Feb 19, 2025
@nrwl nrwl deleted a comment from github-actions Bot Feb 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-30082-6c4c183 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-30082-6c4c183
Release details 📑
Published version 0.0.0-pr-30082-6c4c183
Triggered by @jaysoo
Branch fix/cra-init
Commit 6c4c183
Workflow run 13422710753

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@jaysoo jaysoo force-pushed the fix/cra-init branch 3 times, most recently from 82f7769 to f9a5277 Compare February 24, 2025 21:41
@jaysoo jaysoo requested a review from a team as a code owner February 25, 2025 13:51
juristr
juristr approved these changes Feb 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works. thank you.

@jaysoo jaysoo merged commit 202b49b into master Feb 25, 2025
@jaysoo jaysoo deleted the fix/cra-init branch February 25, 2025 19:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@juristr juristr juristr approved these changes

@JamesHenry JamesHenry JamesHenry left review comments

@leosvelperez leosvelperez Awaiting requested review from leosvelperez leosvelperez was automatically assigned from nrwl/nx-core-reviewers

@mandarini mandarini Awaiting requested review from mandarini mandarini was automatically assigned from nrwl/nx-react-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaysoo @juristr @JamesHenry