Skip to content

fix(release): ensure tags for version match stable variant before prerelease#30047

Merged
JamesHenry merged 1 commit intomasterfrom
release-tag-order
Feb 14, 2025
Merged

fix(release): ensure tags for version match stable variant before prerelease#30047
JamesHenry merged 1 commit intomasterfrom
release-tag-order

Conversation

@JamesHenry
Copy link
Copy Markdown
Contributor

Current Behavior

Versions with a -suffix (prereleases) would be matched before ones without (stable) releases for the same version number.

E.g. v1.0.0-beta.1 would be matched before v1.0.0 even though based on the lifecycle of development, v1.0.0 would be the latest release.

This is shown by the included e2e test which failed before this change, and passes after it.

Expected Behavior

The included e2e test passes.

Related Issue(s)

Fixes #27577

@JamesHenry JamesHenry requested a review from a team as a code owner February 14, 2025 13:15
@JamesHenry JamesHenry requested a review from xiongemi February 14, 2025 13:15
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Feb 14, 2025 1:15pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Feb 14, 2025

View your CI Pipeline Execution ↗ for commit 02a04eb.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 37m 14s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 11s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 10s View ↗
nx documentation ✅ Succeeded 1m 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-14 13:59:14 UTC

@JamesHenry JamesHenry merged commit 888957a into master Feb 14, 2025
@JamesHenry JamesHenry deleted the release-tag-order branch February 14, 2025 16:08
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nx release with conventional commit incorrectly reading prerelease version as the most recent version

2 participants