feat(core): add multi hash fn#29935
Merged
AgentEnder merged 5 commits intomasterfrom Feb 13, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit d2702ae.
☁️ Nx Cloud last updated this comment at |
3b7bf05 to
9b48db9
Compare
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-29935-9b48db9 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-29935-9b48db9
To request a new release for this pull request, mention someone from the Nx team or the |
69b1c71 to
eb72bfc
Compare
eb72bfc to
b2840f8
Compare
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-29935-b2840f8 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-29935-b2840f8
To request a new release for this pull request, mention someone from the Nx team or the |
b2840f8 to
eb23e4b
Compare
eb23e4b to
7872f76
Compare
Cammisuli
approved these changes
Feb 13, 2025
Member
Cammisuli
left a comment
There was a problem hiding this comment.
Small comments, but I wont block the approval.
7872f76 to
d2702ae
Compare
jaysoo
pushed a commit
that referenced
this pull request
Feb 13, 2025
Improve the perf of the `@nx/js/typescript` plugin both in cold and warm scenarios. The main changes done are: - Batch some processing to do it once instead of doing it per config file (avoids some duplicated processing) - Use a custom TS host to read tsconfig files to reduce I/O operations - Cache tsconfig files' reads Benchmark results in a repo with 656 TS projects: ``` # Before the changes Cold (NX_CACHE_PROJECT_GRAPH=false): ~2285 ms Warm (NX_CACHE_PROJECT_GRAPH=true): ~2142 ms # After the changes Cold (NX_CACHE_PROJECT_GRAPH=false): ~597 ms Warm (NX_CACHE_PROJECT_GRAPH=true): ~220 ms ``` Note: Once #29935 is merged. I'll send another change to batch the file hashes. ## Current Behavior ## Expected Behavior ## Related Issue(s) Fixes #
jaysoo
pushed a commit
that referenced
this pull request
Feb 14, 2025
Improve the perf of the `@nx/js/typescript` plugin both in cold and warm scenarios. The main changes done are: - Batch some processing to do it once instead of doing it per config file (avoids some duplicated processing) - Use a custom TS host to read tsconfig files to reduce I/O operations - Cache tsconfig files' reads Benchmark results in a repo with 656 TS projects: ``` # Before the changes Cold (NX_CACHE_PROJECT_GRAPH=false): ~2285 ms Warm (NX_CACHE_PROJECT_GRAPH=true): ~2142 ms # After the changes Cold (NX_CACHE_PROJECT_GRAPH=false): ~597 ms Warm (NX_CACHE_PROJECT_GRAPH=true): ~220 ms ``` Note: Once #29935 is merged. I'll send another change to batch the file hashes. ## Current Behavior ## Expected Behavior ## Related Issue(s) Fixes #
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #