Skip to content

feat(angular): add convert-to-rspack generator#29860

Merged
Coly010 merged 7 commits intomasterfrom
angular/convert-to-rspack
Mar 14, 2025
Merged

feat(angular): add convert-to-rspack generator#29860
Coly010 merged 7 commits intomasterfrom
angular/convert-to-rspack

Conversation

@Coly010
Copy link
Copy Markdown
Contributor

@Coly010 Coly010 commented Feb 3, 2025 •
edited
Loading

Current Behavior

Nx currently does not offer an automated method for switching from an Angular Webpack build to an Angular Rspack build.

Expected Behavior

Provide a generator convert-to-rspack in @nx/angular that will allow conversion from an Angular Webpack build to an Angular Rspack build.

Usage: nx g convert-to-rspack --project=myapp

TODO

  • handle more builder options
  • take existing custom webpack configs and migrate into the rspack config that is created

@Coly010 Coly010 self-assigned this Feb 3, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Mar 14, 2025 4:38pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Feb 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 779db90.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 18m 59s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=398ab... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-14 17:11:06 UTC

HaasStefan
HaasStefan reviewed Feb 3, 2025
View reviewed changes
Comment thread packages/angular/src/generators/convert-to-rspack/convert-to-rspack.ts
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from 60af78b to 43e1fcb Compare February 4, 2025 09:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 4, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-29860-43e1fcb my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-29860-43e1fcb
Release details 📑
Published version 0.0.0-pr-29860-43e1fcb
Triggered by @Coly010
Branch angular/convert-to-rspack
Commit 43e1fcb
Workflow run 13133852282

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from 43e1fcb to 9bb61d3 Compare February 10, 2025 09:48
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from 9bb61d3 to 6504b20 Compare February 17, 2025 11:20
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from 6504b20 to 74361a9 Compare February 17, 2025 13:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 17, 2025

Failed to publish a PR release of this pull request, triggered by @Coly010.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/13371689255

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 17, 2025

Failed to publish a PR release of this pull request, triggered by @Coly010.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/13371689255

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 17, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-29860-74361a9 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-29860-74361a9
Release details 📑
Published version 0.0.0-pr-29860-74361a9
Triggered by @Coly010
Branch angular/convert-to-rspack
Commit 74361a9
Workflow run 13371689255

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch 2 times, most recently from eff0dd6 to e50fda7 Compare February 20, 2025 12:00
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch 2 times, most recently from 9debbaf to 2cec332 Compare March 3, 2025 12:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-29860-2cec332 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-29860-2cec332
Release details 📑
Published version 0.0.0-pr-29860-2cec332
Triggered by @Coly010
Branch angular/convert-to-rspack
Commit 2cec332
Workflow run 13632631050

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from 2cec332 to f2b8130 Compare March 3, 2025 15:33
@LayZeeDK
Copy link
Copy Markdown
Contributor

LayZeeDK commented Mar 5, 2025

question: Any way to make this work with Nx 18.3 and Angular 17.3?

@LayZeeDK
Copy link
Copy Markdown
Contributor

LayZeeDK commented Mar 5, 2025

Guide at https://angular-rspack.dev/guide/migration/from-webpack

@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch 2 times, most recently from 2818f1b to ba00de3 Compare March 12, 2025 13:38
@Coly010
Copy link
Copy Markdown
Contributor Author

Coly010 commented Mar 12, 2025

question: Any way to make this work with Nx 18.3 and Angular 17.3?

Currently Angular Rspack is only supporting Angular 19

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 13, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-29860-d639246 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-29860-d639246
Release details 📑
Published version 0.0.0-pr-29860-d639246
Triggered by @Coly010
Branch angular/convert-to-rspack
Commit d639246
Workflow run 13834439518

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from d1cffbe to 0644997 Compare March 13, 2025 13:04
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from 0644997 to 923f9a6 Compare March 13, 2025 13:33
@Coly010 Coly010 marked this pull request as ready for review March 13, 2025 13:44
@Coly010 Coly010 requested review from a team, AgentEnder, FrozenPandaz and jaysoo as code owners March 13, 2025 13:44
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from fdcf3b4 to 632966a Compare March 13, 2025 20:37
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from 9df6faf to c1b1a0d Compare March 14, 2025 13:30
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from dd9e12e to 779db90 Compare March 14, 2025 16:29
@Coly010 Coly010 enabled auto-merge (squash) March 14, 2025 16:48
@Coly010 Coly010 merged commit 0082081 into master Mar 14, 2025
@Coly010 Coly010 deleted the angular/convert-to-rspack branch March 14, 2025 17:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@leosvelperez leosvelperez leosvelperez approved these changes

@jaysoo jaysoo Awaiting requested review from jaysoo

@AgentEnder AgentEnder Awaiting requested review from AgentEnder

+1 more reviewer

@HaasStefan HaasStefan HaasStefan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Coly010 Coly010

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Coly010 @LayZeeDK @FrozenPandaz @leosvelperez @HaasStefan