fix(core): allow postTaskExecution hook without preTaskExecution hook#29820
Merged
FrozenPandaz merged 2 commits intonrwl:masterfrom Jan 31, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 5c031d6.
☁️ Nx Cloud last updated this comment at |
Cammisuli
approved these changes
Jan 31, 2025
FrozenPandaz
approved these changes
Jan 31, 2025
Contributor
FrozenPandaz
left a comment
There was a problem hiding this comment.
Thank you for your contribution! LGTM 🎉
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
postTaskExecutionhook is only called ifpreTaskExecutionhook is exported in the plugin.Expected Behavior
postTaskExecutionhook should be independent frompreTaskExecutionhook. I.e., ifpreTaskExecutionhook is not exported,postTaskExecutionhook should still be called after a task execution.Related Issue(s)
Fixes #
Fixed
postTaskExecutionhook