Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 91c05d3.
☁️ Nx Cloud last updated this comment at |
44c0905 to
91c05d3
Compare
leosvelperez
approved these changes
Jan 30, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Our Module Federation Config allows passing tuple remotes:
However, if the Module Federation system is expecting the remotes to be loaded as Global variables in the browser, then we erroneously pass just the url to webpack/rspack's
extractUrlAndGlobalmethod.This expects a string of format
name@url. For non-tuple remote configurations, we create this correctly.However, when a tuple is passed, we simply return the url.
Expected Behavior
We should ensure that the string is massaged to
name@urleven when a tuple is provided.