Skip to content

fix(react): add release option for @nx/react:lib --publishable#29776

Merged
JamesHenry merged 1 commit intomasterfrom
feature/nxc-1384-release-option-is-not-added-to-nxreact-publishable
Feb 15, 2025
Merged

fix(react): add release option for @nx/react:lib --publishable#29776
JamesHenry merged 1 commit intomasterfrom
feature/nxc-1384-release-option-is-not-added-to-nxreact-publishable

Conversation

@xiongemi
Copy link
Copy Markdown
Contributor

@xiongemi xiongemi commented Jan 28, 2025

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 3:26pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jan 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 86ceff1.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 29m 44s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 24s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 12s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 10s View ↗
nx documentation ✅ Succeeded 2m 8s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-14 16:00:38 UTC

@xiongemi xiongemi force-pushed the feature/nxc-1384-release-option-is-not-added-to-nxreact-publishable branch 2 times, most recently from 1ce63c4 to fe489b4 Compare January 30, 2025 06:10
@xiongemi xiongemi marked this pull request as ready for review January 30, 2025 06:59
@xiongemi xiongemi requested review from a team as code owners January 30, 2025 06:59
@xiongemi xiongemi force-pushed the feature/nxc-1384-release-option-is-not-added-to-nxreact-publishable branch 2 times, most recently from 1122711 to bc5bb53 Compare February 4, 2025 04:47
@xiongemi xiongemi force-pushed the feature/nxc-1384-release-option-is-not-added-to-nxreact-publishable branch 7 times, most recently from 616bad6 to 6f33ec6 Compare February 12, 2025 02:35
@xiongemi xiongemi force-pushed the feature/nxc-1384-release-option-is-not-added-to-nxreact-publishable branch 3 times, most recently from a6c4505 to 5e801db Compare February 12, 2025 07:18
JamesHenry
JamesHenry requested changes Feb 12, 2025
View reviewed changes
Comment thread packages/react/src/generators/library/library.ts Outdated
JamesHenry
JamesHenry reviewed Feb 12, 2025
View reviewed changes
Comment thread packages/react/src/generators/library/schema.d.ts Outdated
JamesHenry
JamesHenry reviewed Feb 12, 2025
View reviewed changes
Comment thread packages/react/src/generators/library/library.ts
JamesHenry
JamesHenry reviewed Feb 12, 2025
View reviewed changes
Comment thread packages/react/src/generators/library/lib/create-files.ts Outdated
@xiongemi xiongemi force-pushed the feature/nxc-1384-release-option-is-not-added-to-nxreact-publishable branch from 5e801db to 5426ef8 Compare February 12, 2025 16:46
@xiongemi xiongemi requested a review from JamesHenry February 12, 2025 18:55
@xiongemi xiongemi force-pushed the feature/nxc-1384-release-option-is-not-added-to-nxreact-publishable branch from 5426ef8 to 10b25a1 Compare February 12, 2025 22:10
@xiongemi xiongemi force-pushed the feature/nxc-1384-release-option-is-not-added-to-nxreact-publishable branch from 10b25a1 to 86ceff1 Compare February 14, 2025 15:23
@JamesHenry JamesHenry merged commit fc39b3d into master Feb 15, 2025
@JamesHenry JamesHenry deleted the feature/nxc-1384-release-option-is-not-added-to-nxreact-publishable branch February 15, 2025 09:27
jaysoo pushed a commit that referenced this pull request Feb 18, 2025
@xiongemi @jaysoo
fix(react): add release option for @nx/react:lib --publishable (#29776)
7df32bf
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 21, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@leosvelperez leosvelperez Awaiting requested review from leosvelperez leosvelperez was automatically assigned from nrwl/nx-core-reviewers

@mandarini mandarini Awaiting requested review from mandarini mandarini was automatically assigned from nrwl/nx-react-reviewers

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz

@MaxKless MaxKless Awaiting requested review from MaxKless

Assignees

@JamesHenry JamesHenry

@xiongemi xiongemi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xiongemi @JamesHenry