fix(testing): infer correct file output paths for atomized targets#29766
Merged
fix(testing): infer correct file output paths for atomized targets#29766
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit b497996.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Jan 27, 2025
fad5ebb to
b497996
Compare
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug when
outputFileis specified inplayright.config.ts, and atomizer is enabled viaciTargetName, then the path of the output file is wrong.For example, if you have this reporters entry:
Then the atomized output file would be something like
dist/report.xml/example-spec-ts, wherereport.xmlis a directory. The correct output file should bedist/example-spec-ts/report.xmlto avoid conflict with the non-atomized output ofdist/report.xml.Current Behavior
If you run
nx e2e projthennx e2e-ci projthen you can run into an issue wherereport.xml(or whatever the file name is) is a directory in the cache, but it is a file currently -- or vice versa. This happens due to the bug described above.Expected Behavior
The
outputFileshould never cause a conflict where a path should be a directory but is currently a file, or vice versa.Related Issue(s)
Fixes #