feat(core): introduce continuous tasks#29750
Merged
FrozenPandaz merged 1 commit intonext-majorfrom Feb 4, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit a137998.
☁️ Nx Cloud last updated this comment at |
66b73fc to
3ce0b72
Compare
3ce0b72 to
9704043
Compare
9704043 to
6273072
Compare
6273072 to
b33ed45
Compare
b33ed45 to
cc9549c
Compare
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-29750-cc9549c my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-29750-cc9549c
To request a new release for this pull request, mention someone from the Nx team or the |
cc9549c to
91e243b
Compare
8bed8d6 to
a0967d3
Compare
bd960c0 to
80f6267
Compare
FrozenPandaz
commented
Jan 31, 2025
| !shouldPrefix | ||
| ) { | ||
| // todo implement this | ||
| // return await this.runTaskInForkedProcess( |
| } | ||
|
|
||
| // endregion utils | ||
| private async startInfiniteTask( |
Contributor
Author
There was a problem hiding this comment.
Change this to continuous
| } | ||
| } | ||
|
|
||
| let i = 0; |
|
|
||
| it('should subscribe to output', (done) => { | ||
| const childProcess = terminal.runCommand('echo "hello world"'); | ||
| const childProcess = terminal.runCommand('sleep 1 && echo "hello world"'); |
1d9c69a to
d54fcbe
Compare
d54fcbe to
16818ee
Compare
afa8cee to
b0c8c5b
Compare
Cammisuli
reviewed
Feb 4, 2025
| } | ||
|
|
||
| async function createProcessWithPseudoTty( | ||
| pseudoTerminal: PseudoTerminal | null, |
Comment on lines
+185
to
+188
| } finally { | ||
| if (this.isAlive == true) { | ||
| this.isAlive = false; | ||
| } |
Member
There was a problem hiding this comment.
This can probably be simplified to just this since we check if its alive above:
Suggested change
| } finally { | |
| if (this.isAlive == true) { | |
| this.isAlive = false; | |
| } | |
| } finally { | |
| this.isAlive = false; |
b0c8c5b to
a137998
Compare
Cammisuli
approved these changes
Feb 4, 2025
FrozenPandaz
added a commit
that referenced
this pull request
Feb 4, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Summary An RFC about this feature is happening here: #29025. This has the most information about this feature. ## Current Behavior <!-- This is the behavior we have today --> Nx currently does not explicitly handle tasks which run continuously until they are terminated. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> This PR adds the initial support for continuous tasks which run continuously until they are terminated. This adds the ability to depend on continuous tasks. There is some more work to be done but this will be enough as an MVP. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
FrozenPandaz
added a commit
that referenced
this pull request
Feb 5, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Summary An RFC about this feature is happening here: #29025. This has the most information about this feature. ## Current Behavior <!-- This is the behavior we have today --> Nx currently does not explicitly handle tasks which run continuously until they are terminated. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> This PR adds the initial support for continuous tasks which run continuously until they are terminated. This adds the ability to depend on continuous tasks. There is some more work to be done but this will be enough as an MVP. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An RFC about this feature is happening here: #29025. This has the most information about this feature.
Current Behavior
Nx currently does not explicitly handle tasks which run continuously until they are terminated.
Expected Behavior
This PR adds the initial support for continuous tasks which run continuously until they are terminated. This adds the ability to depend on continuous tasks. There is some more work to be done but this will be enough as an MVP.
Related Issue(s)
Fixes #