Skip to content

feat(nx-dev): refactor and improve style of video-player#29749

Merged
juristr merged 1 commit intomasterfrom
nxdev/refactor-video-player-cmp
Jan 28, 2025
Merged

feat(nx-dev): refactor and improve style of video-player#29749
juristr merged 1 commit intomasterfrom
nxdev/refactor-video-player-cmp

Conversation

@juristr
Copy link
Copy Markdown
Member

@juristr juristr commented Jan 24, 2025

Removes obsolete unused parts and refactors how embedded videos are rendered

Current Behavior

image

Expected Behavior

image

@juristr juristr requested a review from a team as a code owner January 24, 2025 16:38
@juristr juristr requested a review from isaacplmann January 24, 2025 16:38
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 27, 2025 3:43pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jan 24, 2025

View your CI Pipeline Execution ↗ for commit 68ed213.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 3m 49s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 54s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=9f712... ✅ Succeeded 16s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 15s View ↗
nx documentation --no-dte ✅ Succeeded 41s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-27 15:44:27 UTC

Comment thread nx-dev/ui-markdoc/src/lib/tags/client-video.component.tsx
@juristr juristr merged commit 5127c15 into master Jan 28, 2025
@juristr juristr deleted the nxdev/refactor-video-player-cmp branch January 28, 2025 08:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants