fix(node): set correct compilerOptions for Nest applications#29725
Merged
fix(node): set correct compilerOptions for Nest applications#29725
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 35c1da4.
☁️ Nx Cloud last updated this comment at |
9f8a9b5 to
6cc54cd
Compare
ndcunningham
approved these changes
Jan 23, 2025
c755584 to
a0d8cb4
Compare
a0d8cb4 to
35c1da4
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 23, 2025
This PR fixes and issue where generating Nest app in the new TS setup results in a build error due to missing `experimentalDecorators` option in tsconfig. Decorators are required for Nest to work, but we do not set it anymore in `tsconfig.base.json` by default. ## Current Behavior Nest apps are broken ## Expected Behavior Nest apps work ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit a0cfe88)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes and issue where generating Nest app in the new TS setup results in a build error due to missing
experimentalDecoratorsoption in tsconfig. Decorators are required for Nest to work, but we do not set it anymore intsconfig.base.jsonby default.Current Behavior
Nest apps are broken
Expected Behavior
Nest apps work
Related Issue(s)
Fixes #