fix(js): do not generate explicit vitest task config for a js library unless adding plugin is disabled#29606
Merged
leosvelperez merged 1 commit intomasterfrom Jan 13, 2025
Merged
Conversation
… unless adding plugin is disabled
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 5884886.
☁️ Nx Cloud last updated this comment at |
ndcunningham
approved these changes
Jan 13, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 15, 2025
… unless adding plugin is disabled (#29606) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Generating a js library with any bundler other than `vite` and with the `vitest` test runner results in an explicit `test` task in the project configuration. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Generating a js library with any bundler other than `vite` and with the `vitest` test runner should not generate an explicit `test` task in the project configuration. The `test` task should be inferred. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit a352c81)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Generating a js library with any bundler other than
viteand with thevitesttest runner results in an explicittesttask in the project configuration.Expected Behavior
Generating a js library with any bundler other than
viteand with thevitesttest runner should not generate an explicittesttask in the project configuration. Thetesttask should be inferred.Related Issue(s)
Fixes #