fix(js): handle resolution from within node_module in the sync generator#29412
Merged
leosvelperez merged 1 commit intonrwl:masterfrom Dec 19, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 154e3ac.
☁️ Nx Cloud last updated this comment at |
932a757 to
c5160da
Compare
leosvelperez
requested changes
Dec 19, 2024
Member
leosvelperez
left a comment
There was a problem hiding this comment.
Thank you! The changes look good to me. Let's just change it to use tree.root instead of importing workspaceRoot.
Contributor
Author
|
Thanks @leosvelperez ! I didn't think about using the tree.root, changes are applied! ✔️ |
5a8b0df to
154e3ac
Compare
ndcunningham
pushed a commit
that referenced
this pull request
Dec 20, 2024
…tor (#29412) closed #29411 <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The resolve function from ts.System returning the full path, and so including the workspaceRoot that is also append by the FsTree ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Resolution within node_modules are correctly followed ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #29411
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed #29411
Current Behavior
The resolve function from ts.System returning the full path, and so including the workspaceRoot that is also append by the FsTree
Expected Behavior
Resolution within node_modules are correctly followed
Related Issue(s)
Fixes #29411