Skip to content

fix(misc): fix misc generation issues with the ts solution setup#29350

Merged
leosvelperez merged 3 commits intomasterfrom
misc/fix-misc-ts-solution-issues
Dec 16, 2024
Merged

fix(misc): fix misc generation issues with the ts solution setup#29350
leosvelperez merged 3 commits intomasterfrom
misc/fix-misc-ts-solution-issues

Conversation

@leosvelperez
Copy link
Copy Markdown
Member

@leosvelperez leosvelperez commented Dec 13, 2024

Fix misc generation issues related to the new TS solution setup:

  • Improve Cypress config default formatting (when no prettier)
  • Remove leftover compiler options from tsconfig.json files
  • Do not add TS path mappings
  • Update outDir for typecheck tasks to be out-tsc/...
  • Generate Nx configuration in package.json files for e2e test runner projects
  • Fix issue with @nx/js:library and --bundler=vite
  • Other smaller changes

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez requested a review from jaysoo December 13, 2024 17:23
@leosvelperez leosvelperez self-assigned this Dec 13, 2024
@leosvelperez leosvelperez requested review from a team and Coly010 as code owners December 13, 2024 17:23
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 3:12pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Dec 13, 2024 •
edited
Loading

Your CI Pipeline Execution ↗ for commit 4431e86 ⏳ is in progress.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 9m, 49s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx format:check --base=012d4... ✅ Succeeded 4s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 0s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 0s View ↗
nx documentation --no-dte ✅ Succeeded 0s View ↗
nx affected -t e2e-macos-local --parallel=1 --b... ✅ Succeeded 1s View ↗

Last updated at 2024-12-16 16:23:22UTC

Sent with 💌 from NxCloud.

jaysoo
jaysoo reviewed Dec 16, 2024
View reviewed changes
Comment thread packages/js/src/generators/library/library.ts
@leosvelperez leosvelperez enabled auto-merge (squash) December 16, 2024 16:08
@leosvelperez leosvelperez merged commit f922e2b into master Dec 16, 2024
@leosvelperez leosvelperez deleted the misc/fix-misc-ts-solution-issues branch December 16, 2024 16:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 22, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jaysoo jaysoo jaysoo approved these changes

@Coly010 Coly010 Awaiting requested review from Coly010

Assignees

@leosvelperez leosvelperez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leosvelperez @jaysoo