Skip to content

fix(react): fix issues with react ts setup#29312

Merged
jaysoo merged 1 commit intomasterfrom
fix/react_ts
Dec 11, 2024
Merged

fix(react): fix issues with react ts setup#29312
jaysoo merged 1 commit intomasterfrom
fix/react_ts

Conversation

@jaysoo
Copy link
Copy Markdown
Member

@jaysoo jaysoo commented Dec 11, 2024

Fixes a couple of things:

  1. React application should ignore eslint.config.js, eslint.config.cjs, and eslint.config.mjs files since they are not part of the app runtime.
  2. React lib generators should always run npm install. It currently runs only when package.json has changed, but we need to run it to link packages regardless of package.json changes.

@jaysoo jaysoo marked this pull request as ready for review December 11, 2024 18:26
@jaysoo jaysoo requested a review from a team as a code owner December 11, 2024 18:26
@jaysoo jaysoo requested a review from Coly010 December 11, 2024 18:26
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 6:29pm

@jaysoo jaysoo merged commit c2eae0e into master Dec 11, 2024
@jaysoo jaysoo deleted the fix/react_ts branch December 11, 2024 20:00
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants