Skip to content

fix(release): make commits separator in git log command more unique#29261

Merged
JamesHenry merged 1 commit intomasterfrom
release-commit-sep
Dec 9, 2024
Merged

fix(release): make commits separator in git log command more unique#29261
JamesHenry merged 1 commit intomasterfrom
release-commit-sep

Conversation

@JamesHenry
Copy link
Copy Markdown
Contributor

Current Behavior

The commits separator ---- used for the git log formatting behind the scenes could potentially appear in the commit body and is not unique enough.

Expected Behavior

We use a separator of |@-------@| which is extremely unlikely to appear organically in a commit message.

Related Issue(s)

Fixes #26241

@JamesHenry JamesHenry requested a review from a team as a code owner December 9, 2024 13:21
@JamesHenry JamesHenry requested a review from xiongemi December 9, 2024 13:21
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Dec 9, 2024 1:21pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Dec 9, 2024

@JamesHenry JamesHenry enabled auto-merge (squash) December 9, 2024 13:26
@JamesHenry JamesHenry merged commit 2c07bf0 into master Dec 9, 2024
@JamesHenry JamesHenry deleted the release-commit-sep branch December 9, 2024 19:43
FrozenPandaz pushed a commit that referenced this pull request Dec 10, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nx release version ignore changes to a package when the associated commit comes from the github "squash and merge" command

2 participants