fix(core): use fork to execute nx generate workspace:preset#29122
Merged
FrozenPandaz merged 3 commits intomasterfrom Dec 3, 2024
Merged
fix(core): use fork to execute nx generate workspace:preset#29122FrozenPandaz merged 3 commits intomasterfrom
FrozenPandaz merged 3 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a03c5fa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-29122-4727ac1 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-29122-4727ac1
To request a new release for this pull request, mention someone from the Nx team or the |
4727ac1 to
ef6a0e4
Compare
FrozenPandaz
requested changes
Dec 2, 2024
FrozenPandaz
approved these changes
Dec 3, 2024
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
On Windows, when packageManager=pnpm,
create-nx-workspacefails due to an issue withchild_process.spawn.Using
spawn, the@nx/workspace:presetgenerator is executed twice whenpackageManager=pnpm, causing the overall create-nx-workspace flow to fail, even though most things have been set up correctly to that point.Using
forkhas shown success.Expected Behavior
Running
create-nx-workspace --packageManager=pnpmshould work on WindowsFixes
Fixes #20222
Fixes #27270
Fixes #22917
Fixes #22312
Fixes #28710
Fixes #28289
Fixes #28235
Fixes #22383
Fixes #21742
Fixes #20270