fix(core): fix misc issues#29114
Merged
FrozenPandaz merged 3 commits intomasterfrom Dec 3, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8ddbc07. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-29114-41d0324 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-29114-41d0324
To request a new release for this pull request, mention someone from the Nx team or the |
41d0324 to
4447aa0
Compare
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-29114-4447aa0 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-29114-4447aa0
To request a new release for this pull request, mention someone from the Nx team or the |
AgentEnder
requested changes
Dec 2, 2024
450ee15 to
4650147
Compare
AgentEnder
approved these changes
Dec 2, 2024
4650147 to
2260002
Compare
f7d2e9d to
b291fac
Compare
7a604ab to
8ddbc07
Compare
FrozenPandaz
added a commit
that referenced
this pull request
Dec 3, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> This PR fixes several issues: 1. Affected loaded plugins again. 2. `package-json` plugin takes a while and is loaded often. 3. Performance logging was not showing up properly. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> 1. Affected does not load plugins again. 2. `package-json` plugin utilizes a cache so that it is fast even when it is loaded often. 3. Performance logging shows up properly ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com> (cherry picked from commit 9ad6b8c)
AgentEnder
added a commit
that referenced
this pull request
Dec 3, 2024
This reverts commit 9ad6b8c.
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
This PR fixes several issues:
package-jsonplugin takes a while and is loaded often.Expected Behavior
package-jsonplugin utilizes a cache so that it is fast even when it is loaded often.Related Issue(s)
Fixes #