fix(core): add missing supported CI providers to NxCloud type#29008
Merged
AgentEnder merged 1 commit intonrwl:masterfrom Nov 20, 2024
Merged
fix(core): add missing supported CI providers to NxCloud type#29008AgentEnder merged 1 commit intonrwl:masterfrom
NxCloud type#29008AgentEnder merged 1 commit intonrwl:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
6b82924 to
c01e676
Compare
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c01e676. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
Nov 20, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 22, 2024
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
CreateWorkspaceOptionsthat is exposed via thecreate-nx-workspacepackage,nx/packages/create-nx-workspace/src/create-workspace-options.ts
Line 7 in a0d760f
has a field named
NxCloudthat only contains the following types:,nx/packages/create-nx-workspace/src/utils/nx/nx-cloud.ts
Line 5 in 1c2ae37
while more CI providers are in fact supported by the underlying code (see
NxCloudChoicesarray inab-testing.ts):nx/packages/create-nx-workspace/src/utils/nx/ab-testing.ts
Line 5 in a0d760f
Expected Behavior
Align the type of
NxCloudto match all supported values fromNxCloudChoicesRelated Issue(s)
Fixes #