Skip to content

fix(nest): repair nestjs service generator schema#28928

Merged
ndcunningham merged 2 commits intonrwl:masterfrom
pawel-twardziak:bugs/NestJS-service-generator-not-working-properly
Nov 14, 2024
Merged

fix(nest): repair nestjs service generator schema#28928
ndcunningham merged 2 commits intonrwl:masterfrom
pawel-twardziak:bugs/NestJS-service-generator-not-working-properly

Conversation

@pawel-twardziak
Copy link
Copy Markdown
Contributor

@pawel-twardziak pawel-twardziak commented Nov 13, 2024 •
edited
Loading

Related Issue(s)

Fixes #28910

@pawel-twardziak pawel-twardziak requested a review from a team as a code owner November 13, 2024 19:48
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 14, 2024 8:59pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Nov 13, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 02d873d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@pawel-twardziak
Copy link
Copy Markdown
Contributor Author

pawel-twardziak commented Nov 13, 2024

Hi @FrozenPandaz & @ndcunningham I still have trouble generating documentation locally - rspack problem or something

@pawel-twardziak
Copy link
Copy Markdown
Contributor Author

pawel-twardziak commented Nov 13, 2024

ok, my rust cargo was outdated, I am updating the documentation

@pawel-twardziak
Copy link
Copy Markdown
Contributor Author

pawel-twardziak commented Nov 13, 2024 •
edited
Loading

@FrozenPandaz @ndcunningham I have no clue why I am still getting these:

obraz

@pawel-twardziak
Copy link
Copy Markdown
Contributor Author

pawel-twardziak commented Nov 13, 2024

I've noticed many changes to documentation scripts - some of them are not windows compatible

@pawel-twardziak
Copy link
Copy Markdown
Contributor Author

pawel-twardziak commented Nov 13, 2024

no way to fix it in no time. It does not work on windows. I would need more time to fix it

@pawel-twardziak
Copy link
Copy Markdown
Contributor Author

pawel-twardziak commented Nov 14, 2024

I've finally achieved what is necessary:

obraz

@pawel-twardziak pawel-twardziak requested a review from a team as a code owner November 14, 2024 20:50
ndcunningham
ndcunningham approved these changes Nov 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@ndcunningham ndcunningham merged commit 3c6c387 into nrwl:master Nov 14, 2024
bcabanes pushed a commit that referenced this pull request Nov 15, 2024
@pawel-twardziak @bcabanes
fix(nest): repair nestjs service generator schema (#28928)
f6c741a 
# Related Issue(s)

Fixes #28910
FrozenPandaz pushed a commit that referenced this pull request Nov 15, 2024
@pawel-twardziak @FrozenPandaz
fix(nest): repair nestjs service generator schema (#28928)
b00b646 
# Related Issue(s)

Fixes #28910

(cherry picked from commit 3c6c387)
nartc pushed a commit that referenced this pull request Nov 15, 2024
@pawel-twardziak @nartc
fix(nest): repair nestjs service generator schema (#28928)
68c78ad 
# Related Issue(s)

Fixes #28910
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 20, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ndcunningham ndcunningham ndcunningham approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ndcunningham ndcunningham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NestJS generator not working properly

2 participants

@pawel-twardziak @ndcunningham