Skip to content

fix(graph): enable action on the ViewOnGraph button regardless of the…#28863

Merged
MaxKless merged 1 commit intonrwl:masterfrom
Ahmed-Hakeem:patch-1
Nov 11, 2024
Merged

fix(graph): enable action on the ViewOnGraph button regardless of the…#28863
MaxKless merged 1 commit intonrwl:masterfrom
Ahmed-Hakeem:patch-1

Conversation

@Ahmed-Hakeem
Copy link
Copy Markdown
Contributor

Current Behavior

ViewOnGraph button doesn't work until you open the accordion

Expected Behavior

ViewOnGraph button should direct to graph without the need to open the accordion first.

I believe it's better from the UX prespective that user shouldn't click twice on the same button to fire its action.

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 9, 2024 4:25am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Nov 9, 2024

Copy link
Copy Markdown
Contributor

@MaxKless MaxKless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well, thanks :)

@MaxKless MaxKless merged commit 3643f66 into nrwl:master Nov 11, 2024
FrozenPandaz pushed a commit that referenced this pull request Nov 11, 2024
#28863)

## Current Behavior
ViewOnGraph button doesn't work until you open the accordion

## Expected Behavior
ViewOnGraph button should direct to graph without the need to open the
accordion first.

I believe it's better from the UX prespective that user shouldn't click
twice on the same button to fire its action.

(cherry picked from commit 3643f66)
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants