fix(core): add workspaces path if package path is not included#28824
Merged
fix(core): add workspaces path if package path is not included#28824
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ae74ec7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
e594984 to
0cf563d
Compare
356f0d7 to
86c4253
Compare
jaysoo
reviewed
Nov 11, 2024
86c4253 to
2e4b8ae
Compare
2e4b8ae to
49bef64
Compare
49bef64 to
781cf08
Compare
a1e76cb to
8156a5d
Compare
8156a5d to
65d614f
Compare
65d614f to
342bfff
Compare
342bfff to
0625b8a
Compare
0625b8a to
e5672f8
Compare
FrozenPandaz
requested changes
Nov 26, 2024
0cd3e68 to
c6c1811
Compare
c6c1811 to
51cb644
Compare
51cb644 to
b3291b6
Compare
b3291b6 to
4438b44
Compare
FrozenPandaz
approved these changes
Dec 5, 2024
4438b44 to
ae74ec7
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 6, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> - when import to a path where is not in the workspaces, it currently just shows a warning. however, it will cause an error like "module not found" because there are packages not installed. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> - automatically add to the workspaces  ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 902eef5)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #