feat(rspack): update withReact plugin for parity with webpack plugin#28812
Merged
feat(rspack): update withReact plugin for parity with webpack plugin#28812
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cbdc5e7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
c4f179a to
3b33b0d
Compare
0466022 to
12741d4
Compare
jaysoo
reviewed
Nov 8, 2024
12741d4 to
1400071
Compare
jaysoo
approved these changes
Nov 8, 2024
1400071 to
fa0dd07
Compare
Coly010
suggested changes
Nov 12, 2024
Contributor
Coly010
left a comment
There was a problem hiding this comment.
Just a circular dep removal and this should be fine.
Has it been tested with Standard React app and with Module Federation?
ba71e74 to
410e86c
Compare
410e86c to
3bf60e4
Compare
…ith the withNx plugin.
3bf60e4 to
cbdc5e7
Compare
Coly010
approved these changes
Nov 12, 2024
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #