fix(core): ensure that setWorkspaceContext is run only on main nx packages#28706
Merged
FrozenPandaz merged 5 commits intomasterfrom Nov 5, 2024
Merged
Conversation
Also makes creation of the archive file more atomic so that we dont overwrite files while its being written by other processes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1c6e035. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28706-16b6403 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28706-16b6403
To request a new release for this pull request, mention someone from the Nx team or the |
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28706-f21dc7c my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28706-f21dc7c
To request a new release for this pull request, mention someone from the Nx team or the |
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28706-97af084 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28706-97af084
To request a new release for this pull request, mention someone from the Nx team or the |
aa33ceb to
1c6e035
Compare
setWorkspaceContext is run only on main nx packages
FrozenPandaz
approved these changes
Nov 5, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 5, 2024
…ackages (#28706) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> When running postinstall with Nx, we create a files archive file. When there are multiple versions of nx installed, the post install would run for all versions. This causes issues where one version might overwrite the archive files while another version is writing to the same location. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The `setupWorkspaceContext` is now only ran when we detect that it is the main nx package. This also makes the creation of the archive file more atomic so that we dont overwrite files while its being written by other processes ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit b925f8c)
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 6, 2024
…ackages (#28706) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> When running postinstall with Nx, we create a files archive file. When there are multiple versions of nx installed, the post install would run for all versions. This causes issues where one version might overwrite the archive files while another version is writing to the same location. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The `setupWorkspaceContext` is now only ran when we detect that it is the main nx package. This also makes the creation of the archive file more atomic so that we dont overwrite files while its being written by other processes ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit b925f8c)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running postinstall with Nx, we create a files archive file. When there are multiple versions of nx installed, the post install would run for all versions. This causes issues where one version might overwrite the archive files while another version is writing to the same location.
Expected Behavior
The
setupWorkspaceContextis now only ran when we detect that it is the main nx package. This also makes the creation of the archive file more atomic so that we dont overwrite files while its being written by other processesRelated Issue(s)
Fixes #