fix(nextjs): Add deprecation message for svgr#28705
Merged
ndcunningham merged 1 commit intomasterfrom Oct 31, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9518255. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
jaysoo
approved these changes
Oct 30, 2024
b214fdb to
9518255
Compare
jaysoo
pushed a commit
that referenced
this pull request
Oct 31, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Currently, if you are using Next.js 15 have SVGR enabled via `WithNx` and are using turbopack. You could potentially have issues loading your svg. This happens because of how webpack imports svg and not having an additional configuration for turbopack (currently it is under the experimental option). ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Moving forward, we can call this out and deprecate the option to be removed in Nx 21. As such should you need to use SVGs it is recommended to do so manually. Something similar to [this comment](vercel/turborepo#4832 (comment)). ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
4 tasks
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, if you are using Next.js 15 have SVGR enabled via
WithNxand are using turbopack. You could potentially have issues loading your svg. This happens because of how webpack imports svg and not having an additional configuration for turbopack (currently it is under the experimental option).Expected Behavior
Moving forward, we can call this out and deprecate the option to be removed in Nx 21. As such should you need to use SVGs it is recommended to do so manually. Something similar to this comment.
Related Issue(s)
Fixes #