fix(release): remove duplicate space character in changelog thank you header#28664
Merged
JamesHenry merged 1 commit intonrwl:masterfrom Nov 20, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dfaa1c2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
baf34bc to
c639983
Compare
JamesHenry
requested changes
Nov 4, 2024
Contributor
JamesHenry
left a comment
There was a problem hiding this comment.
Thank you, CI is failing FYI
6a6a88a to
dfaa1c2
Compare
Contributor
Author
|
@JamesHenry seems you have already fixed that isse here: 7171536 👍🏼 I've rebased my PR and now includes only the white space fix. |
JamesHenry
approved these changes
Nov 20, 2024
Contributor
|
Thank you @thdk! |
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The nx release changelog command currently generates a changelog that is not formatted properly. It contains two spaces in the
Thank youheader .Expected Behavior
Only once space should be added.