fix(release): support workspace root as a subdirectory of git root#28650
Merged
JamesHenry merged 3 commits intonrwl:masterfrom Nov 11, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0945a46. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
df7035a to
57ae9c6
Compare
57ae9c6 to
ca5accc
Compare
JamesHenry
requested changes
Nov 11, 2024
Contributor
JamesHenry
left a comment
There was a problem hiding this comment.
Thank you! Using --relative is a good suggestion
Contributor
|
I applied my suggestions via the github UI and synced with the latest |
JamesHenry
approved these changes
Nov 11, 2024
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed #27995
Current Behavior
If workspace root is a subdirectory of git root, then running always shows
Expected Behavior
Changes made inside the workspace should be considered for release.
Related Issue(s)
Fixes #27995