fix(linter): move eslint-config-prettier to the end for proper override#28503
Merged
leosvelperez merged 9 commits intomasterfrom Nov 19, 2024
unknown repository
Merged
fix(linter): move eslint-config-prettier to the end for proper override#28503leosvelperez merged 9 commits intomasterfrom unknown repository
leosvelperez merged 9 commits intomasterfrom
unknown repository
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 303548d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
leosvelperez
requested changes
Nov 15, 2024
Member
leosvelperez
left a comment
There was a problem hiding this comment.
Thank you for taking the time to contribute!
The change looks good to me. There's only a minor change suggested to the source code comments.
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 22, 2024
…de (#28503) There is a conflict between ESLint and Prettier rules, which causes incorrect formatting behavior. Reordering the config so that `eslint-config-prettier` is applied last ensures proper rule overrides and resolves conflicts with Prettier. --------- Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com> (cherry picked from commit 25909b0)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a conflict between ESLint and Prettier rules, which causes incorrect formatting behavior.
Reordering the config so that
eslint-config-prettieris applied last ensures proper rule overrides and resolves conflicts with Prettier.