Skip to content

fix(core): add migration to set useLegacyCache by default#28454

Merged
JamesHenry merged 2 commits intomasterfrom
disable-db-cache-for-migrating-workspaces
Oct 15, 2024
Merged

fix(core): add migration to set useLegacyCache by default#28454
JamesHenry merged 2 commits intomasterfrom
disable-db-cache-for-migrating-workspaces

Conversation

@Cammisuli
Copy link
Copy Markdown
Member

@Cammisuli Cammisuli commented Oct 15, 2024 •
edited
Loading

Current Behavior

Existing workspaces that migrate to v20 use the db cache by default.

Expected Behavior

Existing workspaces that migrate to v20 have useLegacyCache set to true. Unless they specifically had enableDbCache from previous versions of Nx. All new workspaces will not have useLegacyCache set by default.

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested a review from a team as a code owner October 15, 2024 18:14
@Cammisuli Cammisuli requested a review from xiongemi October 15, 2024 18:14
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 7:14pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Oct 15, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 09a7fce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@Cammisuli Cammisuli force-pushed the disable-db-cache-for-migrating-workspaces branch from a24ec2c to 22f93ad Compare October 15, 2024 18:19
@Cammisuli Cammisuli enabled auto-merge (squash) October 15, 2024 18:51
@jaysoo jaysoo disabled auto-merge October 15, 2024 18:53
@JamesHenry JamesHenry enabled auto-merge (squash) October 15, 2024 19:53
@JamesHenry JamesHenry merged commit 72292c7 into master Oct 15, 2024
@JamesHenry JamesHenry deleted the disable-db-cache-for-migrating-workspaces branch October 15, 2024 20:05
jaysoo pushed a commit that referenced this pull request Oct 15, 2024
@Cammisuli @jaysoo
fix(core): add migration to set useLegacyCache by default (#28454)
145fe01
@sleeyax
Copy link
Copy Markdown

sleeyax commented Oct 21, 2024

Is it possible to migrate an existing workspace to the db cache instead? Can't seem to find this documented anywhere.

@JamesHenry
Copy link
Copy Markdown
Contributor

JamesHenry commented Oct 21, 2024

@sleeyax Just migrate to Nx 20 as normal, and remove this useLegacyCache flag from your nx.json if it is present. I would advise running nx reset any time after your make changes related to the cache (such as adding or removing this flag).

@sleeyax
Copy link
Copy Markdown

sleeyax commented Oct 21, 2024

Gotcha, thanks for the info!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 27, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jaysoo jaysoo jaysoo approved these changes

@JamesHenry JamesHenry JamesHenry approved these changes

@xiongemi xiongemi Awaiting requested review from xiongemi xiongemi was automatically assigned from nrwl/nx-core-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cammisuli @sleeyax @JamesHenry @jaysoo