Skip to content

feat(core): support rollup.config.ts#28240

Merged
Coly010 merged 6 commits intonrwl:masterfrom
ThePlenkov:nx-rollup-config-plugins
Dec 12, 2024
Merged

feat(core): support rollup.config.ts#28240
Coly010 merged 6 commits intonrwl:masterfrom
ThePlenkov:nx-rollup-config-plugins

Conversation

@ThePlenkov
Copy link
Copy Markdown
Contributor

I would like to be able to use rollup.config.ts. Same way it's used by rollup and vite teams too.

Current Behavior

Currently nx plugin does not reconize project containing rollup.config.ts. It expects only {c|m}js files

Expected Behavior

When project has rollup.config.ts rollup plugin infers build target automatically. This build target should be able to find the rollup.config.ts. For that purpose a special configPlugin CLI parameter should be used

Related Issue(s)

Feature request #28226

@ThePlenkov ThePlenkov requested a review from a team as a code owner October 2, 2024 13:48
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 4:04pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Oct 2, 2024

@ThePlenkov ThePlenkov requested a review from a team as a code owner October 2, 2024 15:12
@ThePlenkov
Copy link
Copy Markdown
Contributor Author

I had to revert forced --configPlugin @rollup/plugin-typescript because it breaks tests for rollup.config.js. Instead I made it optional. I analyze detected config path extension. If it's ts - then we load typescript config plugin, otherwise we just load the config as is.

@ThePlenkov
Copy link
Copy Markdown
Contributor Author

it says pipeline is cancelled. I do not see any error logs..

@Coly010 Coly010 force-pushed the nx-rollup-config-plugins branch from b3d8072 to 27a6d55 Compare December 11, 2024 16:02
@Coly010 Coly010 merged commit f96fda9 into nrwl:master Dec 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 18, 2024
@ThePlenkov ThePlenkov deleted the nx-rollup-config-plugins branch February 11, 2025 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants