feat(misc)!: handle v20 deprecations in plugins#28222
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8a5701a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
1d65888 to
961aada
Compare
961aada to
018ab9d
Compare
018ab9d to
8a5701a
Compare
ndcunningham
approved these changes
Oct 2, 2024
FrozenPandaz
approved these changes
Oct 2, 2024
| import * as rollup from 'rollup'; | ||
|
|
||
| // TODO(v20): This should be deprecated and removed in v22. | ||
| // TODO(v22): Remove this in Nx 22 and migrate to explicit rollup.config.js files. |
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes these from v20 since they were deprecated and slated for removal:
executeWebpackDevServerBuilderexport from@nx/angular/executors, users should useexecuteDevServerBuilderwithStylusutil from@nx/next/plugins/with-stylussince it was deprecated in v17 and has just throw an error that users need to use SASS with Next.jsThe
getRollupOptionsfunction from@nx/react/plugins/bundle-rolluphas been deprecated as mention previously and slated for removal in v22. New users are using inferred targets from Rollup, and existing projects using this module should runnx g @nx/rollup:convert-to-inferredor manually update rollup config to usewithNxfunction.Also, bumped some deprecation for later in v21:
import ReactComponent from './img.svg?svgr')isolatedConfigfrom Webpack executor -- requires a migration that extracts to a standard webpack config just in case (different from the original one that extracts towithNx)The ESLint TODOs were rescoped to
TODO(eslint)and we'll look at it in further flat config work rather than tying it to an Nx release.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #