Skip to content

fix(module-federation): additionalShared should check node_modules when applying to support transitive deps #28137#28216

Merged
Coly010 merged 1 commit intomasterfrom
module-federation/additional-shared-should-check-node-modules
Oct 1, 2024
Merged

fix(module-federation): additionalShared should check node_modules when applying to support transitive deps #28137#28216
Coly010 merged 1 commit intomasterfrom
module-federation/additional-shared-should-check-node-modules

Conversation

@Coly010
Copy link
Copy Markdown
Contributor

@Coly010 Coly010 commented Oct 1, 2024

Current Behavior

Transitive deps may not exist on the project graph or be installed in the root package.json file.
They could require the singleton pattern and should use the additionalShared functionality.

However, the additionalShared will check project graph and root package.json, erroring if the package cannot be found.

The last resort should be to use require.resolve to check the node_modules folder to find the package.json of the package and select a version from it.

Expected Behavior

Related Issue(s)

Fixes #28137

@Coly010 Coly010 requested a review from jaysoo as a code owner October 1, 2024 09:32
@Coly010 Coly010 self-assigned this Oct 1, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 9:34am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Oct 1, 2024

@Coly010 Coly010 merged commit e0f2f02 into master Oct 1, 2024
@Coly010 Coly010 deleted the module-federation/additional-shared-should-check-node-modules branch October 1, 2024 12:55
FrozenPandaz pushed a commit that referenced this pull request Oct 1, 2024
…en applying to support transitive deps #28137 (#28216)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Transitive deps may not exist on the project graph or be installed in
the root package.json file.
They could require the singleton pattern and should use the
`additionalShared` functionality.

However, the additionalShared will check project graph and root
package.json, erroring if the package cannot be found.

The last resort should be to use `require.resolve` to check the
node_modules folder to find the package.json of the package and select a
version from it.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #28137
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 7, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sharing sub packages when collecting shared packages for the Module Federation setup.

2 participants