Skip to content

feat(misc): enable new ts minimal setup by default and guard execution of generators with no support for it#28199

Merged
jaysoo merged 1 commit intomasterfrom
js/enable-new-ts-setup
Oct 2, 2024
Merged

feat(misc): enable new ts minimal setup by default and guard execution of generators with no support for it#28199
jaysoo merged 1 commit intomasterfrom
js/enable-new-ts-setup

Conversation

@leosvelperez
Copy link
Copy Markdown
Member

@leosvelperez leosvelperez commented Sep 30, 2024 •
edited
Loading

  • Enable generating the new & minimal TS setup by default when generating the ts preset with CNW.
    The existing NX_ADD_TS_PLUGIN environment variable is kept with its default value inverted and set to true. It can be used to opt out of the new TS setup by running CNW with NX_ADD_TS_PLUGIN=false.
  • Throw an error when running generators that don't yet support the new TS setup.
    • We'll add support for those generators incrementally in follow-up PRs.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 7:42am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Sep 30, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f4859bc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez force-pushed the js/enable-new-ts-setup branch from caf24a2 to bbfad13 Compare October 1, 2024 08:33
@leosvelperez leosvelperez changed the title feat(misc): WIP feat(misc): enable new ts minimal setup by default and guard execution of generators with no support for it Oct 1, 2024
@leosvelperez leosvelperez self-assigned this Oct 1, 2024
@leosvelperez leosvelperez marked this pull request as ready for review October 1, 2024 09:15
@leosvelperez leosvelperez force-pushed the js/enable-new-ts-setup branch from bbfad13 to 2652ec5 Compare October 1, 2024 11:39
@leosvelperez leosvelperez force-pushed the js/enable-new-ts-setup branch from 2652ec5 to f4859bc Compare October 2, 2024 07:39
@jaysoo jaysoo merged commit ec801b4 into master Oct 2, 2024
@jaysoo jaysoo deleted the js/enable-new-ts-setup branch October 2, 2024 12:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jaysoo jaysoo jaysoo approved these changes

@Coly010 Coly010 Awaiting requested review from Coly010

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz

@vsavkin vsavkin Awaiting requested review from vsavkin

@AgentEnder AgentEnder Awaiting requested review from AgentEnder

@JamesHenry JamesHenry Awaiting requested review from JamesHenry

Assignees

@leosvelperez leosvelperez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leosvelperez @jaysoo