Skip to content

feat(react): make vitest the default test runner since it supports ESM and different moduleResolution better#28153

Merged
jaysoo merged 1 commit intomasterfrom
feat/vitest-default
Sep 30, 2024
Merged

feat(react): make vitest the default test runner since it supports ESM and different moduleResolution better#28153
jaysoo merged 1 commit intomasterfrom
feat/vitest-default

Conversation

@jaysoo
Copy link
Copy Markdown
Member

@jaysoo jaysoo commented Sep 26, 2024

This PR updates the default test runner for React/Web apps to be vitest. It aligned better with our emphasis on modern tooling, and the lack of ESM and proper TS support (using module other than commonjs) in Jest makes it hard to use in some workspaces.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested review from a team and Coly010 as code owners September 26, 2024 23:16
@jaysoo jaysoo requested a review from isaacplmann September 26, 2024 23:16
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 28, 2024 6:17pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Sep 26, 2024

Rucellmai61

This comment was marked as spam.

@jaysoo jaysoo merged commit 85877e3 into master Sep 30, 2024
@jaysoo jaysoo deleted the feat/vitest-default branch September 30, 2024 13:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 7, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants