Skip to content

ignoring vite.config temporary files - gitignore doesn't support brace expansion #28685

@JoA-MoS

Description

@JoA-MoS

Current Behavior

In recent update added **/vite.config.{js,ts,mjs,mts,cjs,cts}.timestamp* to the .gitignore file but the ignore file doesn't support brace expansion.

also it doesn't need the **/ at the begining of the string which would better follow how previous file ignores have been added.

https://git-scm.com/docs/gitignore

Expected Behavior

file like vite.config.mts.timestamp-1728501368696-41bfd7a885ddf.mjs should be ignored

GitHub Repo

No response

Steps to Reproduce

Run the migrations for 20.0.6 that add the line to the gitignore then create a file and see if it is actually ignored.

Nx Report

NX   Report complete - copy this into the issue template

Node           : 20.14.0
OS             : darwin-arm64
Native Target  : aarch64-macos
npm            : 10.7.0

nx (global)        : 20.0.0
nx                 : 20.0.6
@nx/js             : 20.0.6
@nx/jest           : 20.0.6
@nx/eslint         : 20.0.6
@nx/workspace      : 20.0.6
@nx/devkit         : 20.0.6
@nx/eslint-plugin  : 20.0.6
@nx/express        : 20.0.6
@nx/node           : 20.0.6
@nx/vite           : 20.0.6
@nx/vue            : 20.0.6
@nx/web            : 20.0.6
@nx/webpack        : 20.0.6
typescript         : 5.5.4
---------------------------------------
Registered Plugins:
@nx/eslint/plugin
@nx/vite/plugin
@nx/jest/plugin
@nx/webpack/plugin

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

I am not sure the gitignore solution actually solves the core issue.

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions